-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rechunk support #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's gooooooooooooo.
Tuned will be in F41 though https://fedoraproject.org/wiki/Changes/TunedAsTheDefaultPowerProfileManagementDaemon But I agree about preferring PPD over Tuned |
Whoops, yeah it does look like an official change for F41, we'll just stick to fedora defaults for now though. PPD has had much better results for battery than tuneD on my AMD framework |
fixed issues with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, my only concern is using a command instead of the build action, but as long as everything builds fine, I'm in full support.
Also +1 to adding nm-tui, I've had issues with the network applet in the past and this will hopefully be a nicer way to work with networking while cosmic sorts out that issue.
* feat: rechunk, remove SELinux workarounds * feat: add nmtui as the GUI is not fully featured
…gs (#55) fix(rechunk): Fix signing by using the appropriate name and change rechunk arguments
- name: Checkout | ||
uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have we added an old Checkout version here?
We'll start getting warnings about Node 14.x
This PR adds rechunk for reducing image size and fixing existing SELinux issues. Rechunk is very much experimental so I'll continue to test over in: https://github.com/gerblesh/cosmic-rechunk but it's looking mostly stable atm. Build times are slightly longer but still reasonable.
This PR also switches the image away from tuneD and instead uses PPD as PPD has been more receptive to changes for better power efficiency on AMD devices.